Re: [PATCH] Fixup no-progress for fetch & clone

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 24, 2007, 01:47 UTC
Message-ID: <Pine.LNX.4.63.0702240245500.22628@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vvehs1gxy.fsf@assigned-by-dhcp.cox.net>

Hi,

On Fri, 23 Feb 2007, Junio C Hamano wrote:

Show 12 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > Since most servers will not have a no-progress aware upload-pack, how 
> > about this? (It is slightly ugly, but at least works...)
> 
> Please no.
> 
> What's "slight" about this ugliness?
> 
> > +		if (no_progress && band != 3 && len > 7 + 5 &&
> > +				!prefixcmp(buf + 7 + len - 5, "done\r"))
> > +			continue;

This is not the part I found ugly. In sideband, there is a lot of 7+len, 8+len, buf+7.

The part I found ugly is having to touch builtin-archive.c

But I agree that we should not include that in mainline git. But at least this patch is in the open for people who care deeply about no-progress _now_...

Ciao, Dscho