Re: [PATCH] Fixup no-progress for fetch & clone

From: Junio C Hamano <junkio@cox.net>
Date: Feb 24, 2007, 08:14 UTC
Message-ID: <7v7iu80y6i.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <alpine.LRH.0.82.0702240005270.29426@xanadu.home>

Nicolas Pitre <nico@cam.org> writes:

> And how would the remote end distinguish how to split the info from the 
> progress noise?  Teaching pack-object about another file descriptor?
> And what happen if pack-object is run locally in that case?

That's true, and your convention to classify line with "\r" noise and others as info is as good as anything, and does not break any existing system, so it is very good one.

> How does that solve the issue with servers (currently all of them) that 
> don't know about the new sideband?

I actually happen to consider that a non problem.

It is true that you can only prepare the client and server side by 1.5.1, and new clients talking to 1.5.0 or older servers would not be able to squelch the noise. But that is _not_ a new problem anyway, and given time the server side will eventually be updated to 1.5.1 or later. If anything else, it would give incentive to people to upgrade their servers to 1.5.1 ;-)