Re: [PATCH] daemon: restore getpeername(0,...) use

From: Jan Engelhardt <jengelh@inai.de>
Date: Sep 8, 2012, 19:20 UTC
Message-ID: <alpine.LNX.2.01.1209082119320.18369@frira.zrqbmnf.qr>
In-Reply-To: <7v1uicuyqi.fsf@alter.siamese.dyndns.org>

On Saturday 2012-09-08 20:59, Junio C Hamano wrote:

Show 15 quoted lines

>> diff --git a/daemon.c b/daemon.c
>> index 4602b46..eaf08c2 100644
>> --- a/daemon.c
>> +++ b/daemon.c
>> @@ -1,3 +1,4 @@
>> +#include <stdbool.h>
>>  #include "cache.h"
>>  #include "pkt-line.h"
>>  #include "exec_cmd.h"
>
>Platform agnostic parts of the code that use "git-compat-util.h"
>(users of "cache.h" are indirectly users of it) are not allowed to
>do platform specific include like this at their beginning.
>
>This is the first use of stdbool.h; what do you need it for?

For the use in setenv(,,true). It was not entirely obvious in which .h to add it; the most reasonable place was daemon.c itself, since the other .c files do not seem to need it.