Re: [PATCH] daemon: restore getpeername(0,...) use
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 8, 2012, 19:03 UTC
- Message-ID
- <7vwr04tjzo.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <k2g0up$28h$1@ger.gmane.org>
"Joachim Schmitz" <jojo@schmitz-digital.de> writes:
>> + setenv("REMOTE_PORT", portbuf, true);
>
> setenv() is not a function available on all plattfomrs.Please do some homework before adding irrelevant noise. At the minimum, run "git grep" to see if we already use it in other places, and investigate why we can use it safely across platforms we already support.