RE: [PATCH] daemon: restore getpeername(0,...) use
- From
Joachim Schmitz <jojo@schmitz-digital.de>
- Date
- Sep 8, 2012, 19:20 UTC
- Message-ID
- <002101cd8df6$f7cab2a0$e76017e0$@schmitz-digital.de>
- In-Reply-To
- <7vwr04tjzo.fsf@alter.siamese.dyndns.org>
Show 16 quoted lines
> From: Junio C Hamano [mailto:gitster@pobox.com]
> Sent: Saturday, September 08, 2012 9:04 PM
> To: Joachim Schmitz
> Cc: git@vger.kernel.org
> Subject: Re: [PATCH] daemon: restore getpeername(0,...) use
>
> "Joachim Schmitz" <jojo@schmitz-digital.de> writes:
>
> >> + setenv("REMOTE_PORT", portbuf, true);
> >
> > setenv() is not a function available on all plattfomrs.
>
> Please do some homework before adding irrelevant noise. At the
> minimum, run "git grep" to see if we already use it in other places,
> and investigate why we can use it safely across platforms we already
> support.Hmm, guess I missed the indirect inclusion of git-compat-util.h And didn't know about 'git grep', so thanks for the hint
Will look closer next time ;-)