git/list[1] front-page[2] threads[3] people[4] search[5] about
 

RE: [PATCH] daemon: restore getpeername(0,...) use

From
Joachim Schmitz <jojo@schmitz-digital.de>
Date
Sep 8, 2012, 19:20 UTC
Message-ID
<002101cd8df6$f7cab2a0$e76017e0$@schmitz-digital.de>
In-Reply-To
<7vwr04tjzo.fsf@alter.siamese.dyndns.org>
Show 16 quoted lines
> From: Junio C Hamano [mailto:gitster@pobox.com]
> Sent: Saturday, September 08, 2012 9:04 PM
> To: Joachim Schmitz
> Cc: git@vger.kernel.org
> Subject: Re: [PATCH] daemon: restore getpeername(0,...) use
> 
> "Joachim Schmitz" <jojo@schmitz-digital.de> writes:
> 
> >> + setenv("REMOTE_PORT", portbuf, true);
> >
> > setenv() is not a function available on all plattfomrs.
> 
> Please do some homework before adding irrelevant noise.  At the
> minimum, run "git grep" to see if we already use it in other places,
> and investigate why we can use it safely across platforms we already
> support.

Hmm, guess I missed the indirect inclusion of git-compat-util.h And didn't know about 'git grep', so thanks for the hint

Will look closer next time ;-)
Previous: Junio C HamanoNext: Junio C Hamano
Message 5 of 16 in “Restore hostname logging in inetd mode”
  1. Jan EngelhardtSep 8, 2012
  2. daemon: restore getpeername(0,...) useJan Engelhardt, Sep 8, 2012
  3. Joachim SchmitzSep 8, 2012
  4. Junio C HamanoSep 8, 2012
  5. Joachim SchmitzSep 8, 2012
  6. Junio C HamanoSep 8, 2012
  7. Jan EngelhardtSep 8, 2012
  8. Jeff KingSep 10, 2012
  9. Joachim SchmitzSep 10, 2012
  10. Jeff KingSep 10, 2012
  11. Joachim SchmitzSep 10, 2012
  12. Jeff KingSep 10, 2012
  13. Joachim SchmitzSep 10, 2012
  14. Jeff KingSep 10, 2012
  15. Junio C HamanoSep 8, 2012
  16. Jan EngelhardtSep 8, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.