Re: [PATCH 02/19] Allow fetch to modify refs
- From
Daniel Barkalow <barkalow@iabervon.org>
- Date
- Oct 30, 2009, 05:56 UTC
- Message-ID
- <alpine.LNX.2.00.0910300151450.14365@iabervon.org>
- In-Reply-To
- <1256839287-19016-3-git-send-email-srabbelier@gmail.com>
On Thu, 29 Oct 2009, Sverre Rabbelier wrote:
Show 36 quoted lines
> From: Daniel Barkalow <barkalow@iabervon.org>
>
> This allows the transport to use the null sha1 for a ref reported to
> be present in the remote repository to indicate that a ref exists but
> its actual value is presently unknown and will be set if the objects
> are fetched.
>
> Also adds documentation to the API to specify exactly what the methods
> should do and how they should interpret arguments.
>
> Signed-off-by: Daniel Barkalow <barkalow@iabervon.org>
> Signed-off-by: Sverre Rabbelier <srabbelier@gmail.com>
> ---
>
> Signed off by me because I rebased it on master and fixed the
> conflicts with nico's patch.
>
> builtin-clone.c | 5 +++--
> transport-helper.c | 4 ++--
> transport.c | 13 +++++++------
> transport.h | 41 +++++++++++++++++++++++++++++++++++++++--
> 4 files changed, 51 insertions(+), 12 deletions(-)
>
> diff --git a/builtin-clone.c b/builtin-clone.c
> index 5762a6f..0042bee 100644
> --- a/builtin-clone.c
> +++ b/builtin-clone.c
> @@ -526,8 +526,9 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
>
> refs = transport_get_remote_refs(transport);
> if (refs) {
> - mapped_refs = wanted_peer_refs(refs, refspec);
> - transport_fetch_refs(transport, mapped_refs);
> + struct ref *ref_cpy = wanted_peer_refs(refs, refspec);
> + mapped_refs = ref_cpy;
> + transport_fetch_refs(transport, ref_cpy);Just drop this hunk; the change doesn't actually do anything. Otherwise, the patch matches what I have.
-Daniel *This .sig left intentionally blank*