Re: clong an empty repo over ssh causes (harmless) fatal
- From
Daniel Barkalow <barkalow@iabervon.org>
- Date
- Sep 2, 2009, 06:02 UTC
- Message-ID
- <alpine.LNX.2.00.0909020159080.28290@iabervon.org>
- In-Reply-To
- <20090902051615.GC12046@coredump.intra.peff.net>
On Wed, 2 Sep 2009, Jeff King wrote:
Show 18 quoted lines
> On Wed, Sep 02, 2009 at 12:33:52AM -0400, Daniel Barkalow wrote: > > > > The patch below seems to work for me, but I'm a little concerned how it > > > might impact other transports. > > > > Does putting a "transport_disconnect(transport);" after the > > "transport_unlock_pack(transport);" in builtin-clone.c also work for you? > > I think that's a cleaner solution, and should future-proof it in case we > > have a future transport that both doesn't disconnect itself after a fetch > > and gives an error message if the connection is dropped suddenly. > > > > It's kind of just an accident that the only transport that cares about > > disconnect very much doesn't care if you've fetched after getting the > > refs. > > It does work, and I think that is a much saner solution for the reasons > you mention. Thanks. Do you want to write it up and submit it, or should > I?
You probably should; I'm not sure when I'd get to putting together a patch, and you did the hard part (figuring out what was going on) anyway.
-Daniel *This .sig left intentionally blank*