git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] clone: disconnect transport after fetching

From
Jeff King <peff@peff.net>
Date
Sep 4, 2009, 02:30 UTC
Message-ID
<20090904023013.GA14651@coredump.intra.peff.net>
In-Reply-To
<20090902063647.GA29559@coredump.intra.peff.net>
On Wed, Sep 02, 2009 at 02:36:47AM -0400, Jeff King wrote:
> This patch just explicitly calls disconnect after we are
> done with the remote end, which sends a flush packet to
> upload-pack and cleanly disconnects, avoiding the error
> message.

I see you applied this with some extra tests. I should have mentioned in the original cover letter that I considered tests but intentionally did not include them.

The problem is that clone forks upload-pack, and then hangs up on it by exiting, and then upload-pack spews the unwanted message. But control has returned to the shell after clone exits, meaning that the message from upload-pack may or may not have gotten there by the time we grep stderr.

So I don't think your test will ever incorrectly show a failure, but I believe that it would pass randomly even without the related fix to the code.

-Peff
Previous: Junio C HamanoNext: Sitaram Chamarty
Message 24 of 25 in “clong an empty repo over ssh causes (harmless) fatal”
  1. Sitaram ChamartyAug 31, 2009
  2. Matthieu MoyAug 31, 2009
  3. Sitaram ChamartyAug 31, 2009
  4. Matthieu MoyAug 31, 2009
  5. Jeff KingAug 31, 2009
  6. Sverre RabbelierAug 31, 2009
  7. Jeff KingAug 31, 2009
  8. Sverre RabbelierAug 31, 2009
  9. Matthieu MoyAug 31, 2009
  10. Jeff KingAug 31, 2009
  11. Björn SteinbrinkAug 31, 2009
  12. Jeff KingAug 31, 2009
  13. Sverre RabbelierAug 31, 2009
  14. Jeff KingSep 1, 2009
  15. Daniel BarkalowSep 2, 2009
  16. Jeff KingSep 2, 2009
  17. Daniel BarkalowSep 2, 2009
  18. clone: disconnect transport after fetchingJeff King, Sep 2, 2009
  19. Sverre RabbelierSep 2, 2009
  20. Jeff KingSep 2, 2009
  21. Sverre RabbelierSep 2, 2009
  22. Daniel BarkalowSep 2, 2009
  23. Junio C HamanoSep 2, 2009
  24. Jeff KingSep 4, 2009
  25. Sitaram ChamartySep 2, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.