git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] clone: disconnect transport after fetching

From
Jeff King <peff@peff.net>
Date
Sep 2, 2009, 07:26 UTC
Message-ID
<20090902072638.GC31528@coredump.intra.peff.net>
In-Reply-To
<fabb9a1e0909020009r3ee28b1fo3cba095abafec9d4@mail.gmail.com>
On Wed, Sep 02, 2009 at 09:09:19AM +0200, Sverre Rabbelier wrote:
Show 6 quoted lines
> On Wed, Sep 2, 2009 at 08:36, Jeff King<peff@peff.net> wrote:
> > As you can see from the commit message, I did a little extra hunting to
> > make sure we are not going to impact any other code paths, and I am
> > pretty sure we are fine.
> 
> Thank you for fixing my mistake :).

You're welcome, though I am not sure it is your mistake. Arguably this is something we should have been doing all along. The point of abstracting transports was that we didn't need to know their details at the outer layer, but in this case we were relying on the fact that no transports (until empty-clone-over-git) needed an explicit transport_disconnect to cleanly hang up on the other end.

So think of it as you exposing a long-standing bug. ;)
-Peff
Previous: Sverre RabbelierNext: Sverre Rabbelier
Message 20 of 25 in “clong an empty repo over ssh causes (harmless) fatal”
  1. Sitaram ChamartyAug 31, 2009
  2. Matthieu MoyAug 31, 2009
  3. Sitaram ChamartyAug 31, 2009
  4. Matthieu MoyAug 31, 2009
  5. Jeff KingAug 31, 2009
  6. Sverre RabbelierAug 31, 2009
  7. Jeff KingAug 31, 2009
  8. Sverre RabbelierAug 31, 2009
  9. Matthieu MoyAug 31, 2009
  10. Jeff KingAug 31, 2009
  11. Björn SteinbrinkAug 31, 2009
  12. Jeff KingAug 31, 2009
  13. Sverre RabbelierAug 31, 2009
  14. Jeff KingSep 1, 2009
  15. Daniel BarkalowSep 2, 2009
  16. Jeff KingSep 2, 2009
  17. Daniel BarkalowSep 2, 2009
  18. clone: disconnect transport after fetchingJeff King, Sep 2, 2009
  19. Sverre RabbelierSep 2, 2009
  20. Jeff KingSep 2, 2009
  21. Sverre RabbelierSep 2, 2009
  22. Daniel BarkalowSep 2, 2009
  23. Junio C HamanoSep 2, 2009
  24. Jeff KingSep 4, 2009
  25. Sitaram ChamartySep 2, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.