Re: Gitk and --no-walk don't play together

From: Jan Engelhardt <jengelh@medozas.de>
Date: Sep 8, 2008, 17:25 UTC
Message-ID: <alpine.LNX.1.10.0809081310260.1621@fbirervta.pbzchgretzou.qr>
In-Reply-To: <adf1fd3d0809080934s67b2a8b1w19aeb3d8e5f8b4ab@mail.gmail.com>

On Monday 2008-09-08 12:34, Santi Bejar wrote:

>
>> in an attempt to only show only the tags in the graph, gitk barfs:
>
>Use the "List references" in the file menu.

Nope, the intention was to have gitk display something like

* Linux 2.6.26
|
* Linux 2.6.25

without any intermediate commits.

>> $ gitk --no-walk v2.6.25 v2.6.26
>> [ Error reading commits: child killed: segmentation violation ]
>
>At least, you should say the git version, the OS and platform.

Right you are. gitk 1.5.4.3 and Linux 2.6.24.7.

>It is the child process that segfaults, you could try "git rev-list
>--no-walk v2.6.25 v2.6.26" directly and even try to debug it?

rev-list completes without any problems. I straced gitk, and see:

	git log --no-color -z --pretty=raw --topo-order
	--parents --boundary --no-walk v2.6.25 v2.6.26

To reproduce:

	git log [with all that arguments] >/dev/null; echo $?
	Segmentation fault
	139

It is fixed in v1.6.0.1-267-gec3a4ba. Bisect identified that 3131b71 fixed it:

    Add "--show-all" revision walker flag for debugging

So case closed and thank you ;-) Jan