Re: Gitk and --no-walk don't play together

From: Dmitry Potapov <dpotapov@gmail.com>
Date: Sep 8, 2008, 19:07 UTC
Message-ID: <20080908190704.GA28210@dpotapov.dyndns.org>
In-Reply-To: <alpine.LNX.1.10.0809081310260.1621@fbirervta.pbzchgretzou.qr>

On Mon, Sep 08, 2008 at 01:25:12PM -0400, Jan Engelhardt wrote:

> rev-list completes without any problems. I straced gitk, and see:
> 
> 	git log --no-color -z --pretty=raw --topo-order
> 	--parents --boundary --no-walk v2.6.25 v2.6.26

git log crashed when it tried to print the boundary commit. It seems the bug exists in all 1.5.4.x and was fixed in 1.5.5. The commit that fixed the bug is 3131b71 when --show-all was added to revision log. The lines that fixed this bug are the following:

Show 14 quoted lines

> diff --git a/log-tree.c b/log-tree.c
> index 1f3fcf1..e9ba6df 100644
> --- a/log-tree.c
> +++ b/log-tree.c
> @@ -278,6 +282,9 @@ void show_log(struct rev_info *opt, const char *sep)
>  		}
>  	}
>  
> +	if (!commit->buffer)
> +		return;
> +
>  	/*
>  	 * And then the pretty-printed message itself
>  	 */

Dmitry