Re: [PATCH 0/2] Move push logic to transport.c

> Hi,
> 
> On Mon, 9 Mar 2009, Daniel Barkalow wrote:
> 
> > On Mon, 9 Mar 2009, Johannes Schindelin wrote:
> > 
> > > On Mon, 9 Mar 2009, Daniel Barkalow wrote:
> > > 
> > > > On Mon, 9 Mar 2009, Johannes Schindelin wrote:
> > > > 
> > > > > On Mon, 9 Mar 2009, Daniel Barkalow wrote:
> > > > > 
> > > > > > On Mon, 9 Mar 2009, Johannes Schindelin wrote:
> > > > > > 
> > > > > > > On Sun, 8 Mar 2009, Daniel Barkalow wrote:
> > > > > > > 
> > > > > > > > It doesn't convert http-push or the rsync transports, largely 
> > > > > > > > because I don't have test setups for rsync or webdav to make sure 
> > > > > > > > that they're still working.
> > > > > > > 
> > > > > > > $ ls t/*http-push*
> > > > > > > t/t5540-http-push.sh
> > > > > > > 
> > > > > > > $ git grep -n test.*rsync t/
> > > > > > > t/t5510-fetch.sh:195:test_expect_success 'fetch via rsync' '
> > > > > > > t/t5510-fetch.sh:206:test_expect_success 'push via rsync' '
> > > > > > > t/t5510-fetch.sh:217:test_expect_success 'push via rsync' '
> > > > > > > 
> > > > > > > It should be just a matter of installing an apache and rsync.
> > > > > > 
> > > > > > And configuring them suitably, yes. That's the part I haven't previously 
> > > > > > done.
> > > > > 
> > > > > If you have to configure apache (or rsync) for the test to run properly, 
> > > > > we have a serious bug in our test suite.  Please share the output in that 
> > > > > case.
> > > > 
> > > > rsync: failed to connect to 127.0.0.1: Connection refused (111)
> > > > rsync error: error in socket IO (code 10) at clientserver.c(104) [receiver=2.6.9]
> > > > fatal: Could not run rsync to get refs
> > > > 
> > > > I mean, I won't need to do anything really special in the configuration, 
> > > > but I do need to have rsyncd running giving access to that directory 
> > > > without any funny mapping on localhost.
> > > 
> > > That is my mistake, I guess.  I tried to be lazy and not change 
> > > transport.c so that it groks "rsync:$(pwd)" style paths.
> > 
> > Oh, I think it's probably not worth allowing rsync:$(pwd) (particularly 
> > since rsync itself seems not to let you say "rsync:" for local paths). 
> 
> This contradicts that:
> 
> > I'll set something up to run rsyncd with an appropriate config, like the 
> > lib-httpd stuff. Oh, and it looks like nobody actually runs the rsync 
> > tests; they're broken by $(pwd) including whitespace, and haven't been 
> > fixed yet.
> 
> If we would support local rsync paths, testing it would be easy.