Re: [PATCH 0/2] Move push logic to transport.c

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 9, 2009, 16:12 UTC
Message-ID: <alpine.DEB.1.00.0903091711180.6358@intel-tinevez-2-302>
In-Reply-To: <alpine.LNX.1.00.0903091200150.19665@iabervon.org>

Hi,

On Mon, 9 Mar 2009, Daniel Barkalow wrote:

Show 20 quoted lines

> On Mon, 9 Mar 2009, Johannes Schindelin wrote:
> 
> > On Sun, 8 Mar 2009, Daniel Barkalow wrote:
> > 
> > > It doesn't convert http-push or the rsync transports, largely 
> > > because I don't have test setups for rsync or webdav to make sure 
> > > that they're still working.
> > 
> > $ ls t/*http-push*
> > t/t5540-http-push.sh
> > 
> > $ git grep -n test.*rsync t/
> > t/t5510-fetch.sh:195:test_expect_success 'fetch via rsync' '
> > t/t5510-fetch.sh:206:test_expect_success 'push via rsync' '
> > t/t5510-fetch.sh:217:test_expect_success 'push via rsync' '
> > 
> > It should be just a matter of installing an apache and rsync.
> 
> And configuring them suitably, yes. That's the part I haven't previously 
> done.

If you have to configure apache (or rsync) for the test to run properly, we have a serious bug in our test suite. Please share the output in that case.

Ciao, Dscho