Re: [PATCH 0/2] Move push logic to transport.c

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Mar 9, 2009, 16:57 UTC
Message-ID: <alpine.LNX.1.00.0903091230430.19665@iabervon.org>
In-Reply-To: <alpine.DEB.1.00.0903091711180.6358@intel-tinevez-2-302>

On Mon, 9 Mar 2009, Johannes Schindelin wrote:

Show 28 quoted lines

> Hi,
> 
> On Mon, 9 Mar 2009, Daniel Barkalow wrote:
> 
> > On Mon, 9 Mar 2009, Johannes Schindelin wrote:
> > 
> > > On Sun, 8 Mar 2009, Daniel Barkalow wrote:
> > > 
> > > > It doesn't convert http-push or the rsync transports, largely 
> > > > because I don't have test setups for rsync or webdav to make sure 
> > > > that they're still working.
> > > 
> > > $ ls t/*http-push*
> > > t/t5540-http-push.sh
> > > 
> > > $ git grep -n test.*rsync t/
> > > t/t5510-fetch.sh:195:test_expect_success 'fetch via rsync' '
> > > t/t5510-fetch.sh:206:test_expect_success 'push via rsync' '
> > > t/t5510-fetch.sh:217:test_expect_success 'push via rsync' '
> > > 
> > > It should be just a matter of installing an apache and rsync.
> > 
> > And configuring them suitably, yes. That's the part I haven't previously 
> > done.
> 
> If you have to configure apache (or rsync) for the test to run properly, 
> we have a serious bug in our test suite.  Please share the output in that 
> case.

rsync: failed to connect to 127.0.0.1: Connection refused (111) rsync error: error in socket IO (code 10) at clientserver.c(104) [receiver=2.6.9] fatal: Could not run rsync to get refs

I mean, I won't need to do anything really special in the configuration, but I do need to have rsyncd running giving access to that directory without any funny mapping on localhost.

The apache test does, in fact, run its own server, so that should be easy enough (although I do need to install an apache with mod_dav.so, which I don't have handy).

	-Daniel
*This .sig left intentionally blank*