Re: [PATCH] clone: create intermediate directories of destination repo

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Jun 24, 2008, 15:20 UTC
Message-ID: <alpine.LNX.1.00.0806241113360.19665@iabervon.org>
In-Reply-To: <20080624080437.GA2581@sigill.intra.peff.net>

On Tue, 24 Jun 2008, Jeff King wrote:

Show 14 quoted lines

> On Tue, Jun 24, 2008 at 12:39:40AM -0700, Junio C Hamano wrote:
> 
> > > The shell version used to use "mkdir -p" to create the repo path, but
> > > the C version just calls "mkdir". Let's replicate the old behavior. In
> > > this case we can simply create the directories leading up to the git
> > > dir. If it's a bare repo, then that is everything that init_db wants
> > > ahead of time. If it isn't bare, then the worktree contains the git dir,
> > > so we create the worktree.
> > 
> > Clever ;-)
> 
> I am worried that it is too clever. I didn't see an obvious way for
> work_tree and git_dir to not have that property, but I think it is still
> worth somebody double-checking.

I think you can specify git_dir and work_tree on the command line, and set them to whatever you want, although I now don't remember whether they're actually both followed for clone (I tried to match the shell version, whose behavior didn't make too much sense to me).

	-Daniel
*This .sig left intentionally blank*