Re: Git clone behaviour change in 1.5.6 (vs 1.5.5.1)

From: Brandon Casey <casey@nrlssc.navy.mil>
Date: Jun 23, 2008, 21:03 UTC
Message-ID: <0YbSdnKH0_SP30-YMV0Y1aH4SO46yc6x_2EA1VGwPtV_CltGk-7wdg@cipher.nrlssc.navy.mil>
In-Reply-To: <20080623203835.GA8105@sigill.intra.peff.net>

Jeff King wrote:

Show 8 quoted lines

> On Mon, Jun 23, 2008 at 03:56:41PM -0400, Daniel Barkalow wrote:
> 
>>> Switching to the 1.5.6 release from 1.5.5.1, I found out that the
>>> rewritten git-clone command changed its behaviour wrt cloning to a
>>> non-existing destination directory structure. In the shell version the
>>> destination (work tree) is created with 'mkdir -p' but in the C
>>> version with just the mkdir() call which doesn't create the parent
>>> directories.

> Here is a partial fix.

There is a mkdir_p() in builtin-merge-recursive.c which calls safe_create_leading_directories() in sha1_file.c

Can these functions be reused?

-brandon