Re: [PATCH] clone: create intermediate directories of destination repo

From: Jeff King <peff@peff.net>
Date: Jun 24, 2008, 08:04 UTC
Message-ID: <20080624080437.GA2581@sigill.intra.peff.net>
In-Reply-To: <7v3an3e0xv.fsf@gitster.siamese.dyndns.org>

On Tue, Jun 24, 2008 at 12:39:40AM -0700, Junio C Hamano wrote:

Show 8 quoted lines

> > The shell version used to use "mkdir -p" to create the repo path, but
> > the C version just calls "mkdir". Let's replicate the old behavior. In
> > this case we can simply create the directories leading up to the git
> > dir. If it's a bare repo, then that is everything that init_db wants
> > ahead of time. If it isn't bare, then the worktree contains the git dir,
> > so we create the worktree.
> 
> Clever ;-)

I am worried that it is too clever. I didn't see an obvious way for work_tree and git_dir to not have that property, but I think it is still worth somebody double-checking.

-Peff