git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin-checkout: use struct lock_file correctly

From
Daniel Barkalow <barkalow@iabervon.org>
Date
Feb 14, 2008, 18:22 UTC
Message-ID
<alpine.LNX.1.00.0802141319380.13593@iabervon.org>
In-Reply-To
<alpine.LSU.1.00.0802141816120.30505@racer.site>
On Thu, 14 Feb 2008, Johannes Schindelin wrote:
> A lock_file instance must not be cleaned up, since an atexit() handler
> will try to access even correctly committed lock_files, since it has
> to make sure that they were correctly committed.

I think the lock_file API changed between when I wrote this code (using other code as reference) and now; could you check that there aren't other things I have to change as well, since I think you were following the lock_file changes at the time, and I wasn't? I got the most obvious one (calling close() on the fd yourself is no longer right, but I didn't know about this one, and I don't know about any further ones, if there are any.)

	-Daniel
*This .sig left intentionally blank*
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 3 of 4 in “Build in checkout”
  1. 11/11 Build in checkoutDaniel Barkalow, Feb 7, 2008
  2. builtin-checkout: use struct lock_file correctlyJohannes Schindelin, Feb 14, 2008
  3. Daniel BarkalowFeb 14, 2008
  4. Johannes SchindelinFeb 14, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.