Re: [PATCH] builtin-checkout: use struct lock_file correctly
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 14, 2008, 18:55 UTC
- Message-ID
- <alpine.LSU.1.00.0802141854280.30505@racer.site>
- In-Reply-To
- <alpine.LNX.1.00.0802141319380.13593@iabervon.org>
Hi,
On Thu, 14 Feb 2008, Daniel Barkalow wrote:
Show 10 quoted lines
> On Thu, 14 Feb 2008, Johannes Schindelin wrote: > > > A lock_file instance must not be cleaned up, since an atexit() handler > > will try to access even correctly committed lock_files, since it has > > to make sure that they were correctly committed. > > I think the lock_file API changed between when I wrote this code (using > other code as reference) and now; could you check that there aren't other > things I have to change as well, since I think you were following the > lock_file changes at the time, and I wasn't?
I think the rest is safe. (Of course, I grepped for "struct lock_file" in the _whole_ working directory).
Ciao, Dscho