From: Daniel Barkalow <barkalow@iabervon.org>
Date: Thu, 14 Feb 2008 18:22:39 GMT
Subject: Re: [PATCH] builtin-checkout: use struct lock_file correctly
Message-ID: <alpine.LNX.1.00.0802141319380.13593@iabervon.org>
In-Reply-To: <alpine.LSU.1.00.0802141816120.30505@racer.site>

On Thu, 14 Feb 2008, Johannes Schindelin wrote:

> A lock_file instance must not be cleaned up, since an atexit() handler
> will try to access even correctly committed lock_files, since it has
> to make sure that they were correctly committed.

I think the lock_file API changed between when I wrote this code (using 
other code as reference) and now; could you check that there aren't other 
things I have to change as well, since I think you were following the 
lock_file changes at the time, and I wasn't? I got the most obvious one 
(calling close() on the fd yourself is no longer right, but I didn't know 
about this one, and I don't know about any further ones, if there are 
any.)

	-Daniel
*This .sig left intentionally blank*