Re: Performance issue of 'git branch'
- From
Linus Torvalds <torvalds@linux-foundation.org>
- Date
- Jul 23, 2009, 02:20 UTC
- Message-ID
- <alpine.LFD.2.01.0907221850000.3352@localhost.localdomain>
- In-Reply-To
- <20090723012207.GA9368@Pilar.aei.mpg.de>
On Thu, 23 Jul 2009, Carlos R. Mafra wrote:
Show 5 quoted lines
> > Let me guess: if you do a "ls -ld .git/refs/heads" you get a very big > > directory, despite it only having three entries in it. > > [mafra@Pilar:linux-2.6]$ ls -ld .git/refs/heads > drwxr-xr-x 2 mafra mafra 4096 2009-07-22 23:01 .git/refs/heads/
Hmm. That's just a single block.
Then I really don't see why the lstat takes so long.
Show 7 quoted lines
> After 'echo 3 > /proc/sys/vm/drop_caches' it still takes too long,
>
> 1248310449.693085 munmap(0x7f50bcd11000, 164) = 0
> 1248310449.693187 lstat(".git/refs/heads/sparse", 0x7fff618c0960) = -1 ENOENT (No such file or directory)
> 1248310449.719112 lstat(".git/refs/heads/stern", 0x7fff618c0960) = -1 ENOENT (No such file or directory)
> 1248310453.014041 fstat(1, {st_mode=S_IFCHR|0620, st_rdev=makedev(136, 3), ...}) = 0
> 1248310453.014183 mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f50bcd11000Use 'strace -T', which shows how long the actual system calls take, rather than '-tt' which just shows when they started.
Maybe the four seconds is something else than the lstat - page faults on the pack-file in between the lstat and the fstat, for example.
> Perhaps I should delete the "stern" branch, but I would like to learn why > it is slowing things, because it also happened before (in fact it is always > like this, afaicr)
Absolutely. Don't delete it until we figure out what takes so long there.
> Do you have another theory? (now .git/refs/heads is empty)
Clearly it's IO, but if that 'lstat()' was just a red herring, then I suspect it's IO on the pack-file. If so, I'd further guess that your VAIO has some pitiful 4200rpm harddisk that is slow as hell and has horrible seek latencies, and the CPU is way overpowered compared to the cruddy disk.
It probably does the object lookup. You can see some debug output if you do
GIT_DEBUG_LOOKUP=1 git branch
and that will show you the patterns. It won't be very pretty, especially if you have several pack-files, but maybe we can figure out what's up.
Hmm. I wonder.. I suspect 'git branch' looks up _all_ refs, and then afterwards it filters them. So even though it only prints out a few branches, maybe it will look at all the tags etc of the whole repository.
Ooh yes. That would do it. It's going to peel and look up every single ref it finds, so it's going to look up _hundreds_ of objects (all the tags, all the commits they point to, etc etc). Even if it then only shows a couple of branches.
Junio, any ideas?
Linus