Re: Performance issue of 'git branch'
- From
- Carlos R. Mafra <crmafra2@gmail.com>
- Date
- Jul 23, 2009, 14:45 UTC
- Message-ID
- <20090723144559.GA20167@Pilar.aei.mpg.de>
- In-Reply-To
- <m3prbr371l.fsf@localhost.localdomain>
On Thu 23.Jul'09 at 5:42:03 -0700, Jakub Narebski wrote:
Show 22 quoted lines
> Linus Torvalds <torvalds@linux-foundation.org> writes: > > > On Thu, 23 Jul 2009, Carlos R. Mafra wrote: > > > > > > Is there another way to check what is going on with that anomalous lstat()? > > > > I really don't think it's the lstat any more. Your directories look small > > and simple, and clearly the indexing made no difference. > > > > See earlier email about using "strace -T" instead of "-tt". Also, I sent > > you a patch to try out just a minute ago, I think that may be it. > > > > > [ perhaps I will try 'perf' after I read how to use it ] > > > > I really like 'perf' (it does what oprofile did for me, but without the > > headaches), but it doesn't help with IO profiling. > > > > I've actually often wanted to have a 'strace' that shows page faults as > > special system calls, but it's sadly nontrivial ;( > > BTW. Would SystemTap help there? Among contributed scripts there is > iotimes, so perhaps it would be possible to have iotrace...
I played a bit with 'blktrace' and 'btrace' and had two terminals open side by side, one with 'strace git branch' and the other with 'blktrace'.
It was pretty obvious that exactly at the point where 'git branch' was stalling (without Linus' patch) -- which I thought had to do with lstat() -- there was a flurry of activity going on in 'btrace' output.
It would be nice if 'btrace' could be somehow unified with 'strace', if that makes any sense.
Here are some numbers from my tests with blktrace (blkparse and btrace):
[root@Pilar mafra]# grep git blkparse-patch.txt |wc -l 811 [root@Pilar mafra]# grep git blkparse-nopatch.txt |wc -l 3479
where those lines with 'git' are something like
8,5 0 677 1.787350654 18591 I R 204488479 + 40 [git] 8,0 0 678 1.787370489 18591 A R 204488783 + 96 <- (8,5) 137529800 8,5 0 679 1.787371886 18591 Q R 204488783 + 96 [git] 8,5 0 680 1.787375378 18591 G R 204488783 + 96 [git] 8,5 0 681 1.787377613 18591 I R 204488783 + 96 [git]
And the summary lines also indicate that the non-patched git makes the disc work much harder:
*************** Without Linus' patch ******************************************
Total (8,5): Reads Queued: 764, 20,008KiB Writes Queued: 0, 0KiB Read Dispatches: 764, 20,008KiB Write Dispatches: 0, 0KiB Reads Requeued: 0 Writes Requeued: 0 Reads Completed: 764, 20,008KiB Writes Completed: 0, 0KiB Read Merges: 0, 0KiB Write Merges: 0, 0KiB IO unplugs: 299 Timer unplugs: 2
Throughput (R/W): 4,003KiB/s / 0KiB/s Events (8,5): 5,266 entries Skips: 0 forward (0 - 0.0%)
************** With Linus' patch **********************************************
Total (sda5): Reads Queued: 171, 3,128KiB Writes Queued: 6, 24KiB Read Dispatches: 171, 3,128KiB Write Dispatches: 2, 24KiB Reads Requeued: 0 Writes Requeued: 0 Reads Completed: 171, 3,128KiB Writes Completed: 2, 24KiB Read Merges: 0, 0KiB Write Merges: 4, 16KiB IO unplugs: 80 Timer unplugs: 0
Throughput (R/W): 1,632KiB/s / 12KiB/s Events (sda5): 1,226 entries Skips: 0 forward (0 - 0.0%)