Re: [PATCH/RFC] sideband: remove line padding (was: Re: [PATCH] progress: use \r as EOL only if isatty(stderr) is true)
- From
Nicolas Pitre <nico@fluxnic.net>
- Date
- Jul 1, 2011, 03:46 UTC
- Message-ID
- <alpine.LFD.2.00.1106302331050.1371@xanadu.home>
- In-Reply-To
- <20110630211329.GC63317@sherwood.local>
On Thu, 30 Jun 2011, Steffen Daode Nurpmeso wrote:
Show 6 quoted lines
> @ Nicolas Pitre <nico@fluxnic.net> wrote (2011-06-29 20:15+0200): > > Why? > > Ok, they don't. (Your initial patch was from 2008, and since > git(1) is evolving very fast, it might have been that padding is > no longer of any use at all.)
But they absolutely still are. What makes you think they aren't anymore?
> So, then, i'm the right person to turn the big wheel:
I'm afraid you'll have to understand _why_ that padding is still needed first. Luckily the various commit messages for sideband.c are well detailed on the reasons for the current code.
Nicolas