Re: [PATCH] progress: use \r as EOL only if isatty(stderr) is true
- From
- Steffen Daode Nurpmeso <sdaoden@googlemail.com>
- Date
- Jun 28, 2011, 18:55 UTC
- Message-ID
- <20110628185556.GB385@sherwood.local>
- In-Reply-To
- <7vwrg5u7oz.fsf@alter.siamese.dyndns.org>
@ Junio C Hamano <gitster@pobox.com> wrote (2011-06-28 20:33+0200):
> [..] > I thought that we try to disable the progress pretty much > everywhere when we are not talking to a tty[..]
That is to say, at least some kind of progress_maybe_applicable() or the like, instead of having things like
builtin/pack-objects.c: progress = isatty(2);
spread out in the code, and just see what 'git grep -F isatty' reports ...
-- Ciao, Steffen sdaoden(*)(gmail.com) () ascii ribbon campaign - against html e-mail /\ www.asciiribbon.org - against proprietary attachments