Re: [PATCH] progress: use \r as EOL only if isatty(stderr) is true
- From
- Steffen Daode Nurpmeso <sdaoden@googlemail.com>
- Date
- Jun 28, 2011, 16:51 UTC
- Message-ID
- <20110628165153.GA59095@sherwood.local>
- In-Reply-To
- <BANLkTinRe=pA=_obCmPKBjJMXH_pDfwCtw@mail.gmail.com>
@ Tay Ray Chuan <rctay89@gmail.com> wrote (2011-06-28 18:27+0200):
> hmm, shouldn't the onus of checking tty fall on to callers of > progress* functions?
I dunno and have no overview of the git(1) codebase. I have a "arena/code.extern.repos/" directory tree and use a shell script which manages it (e.g. "$ arena-manager update" to pull all repos). The output of this script is (also) redirected into a log file via tee(1), and for git(1) invocations the resulting output is not very useful.
I agree that it is maybe silly to not use --no-progress from within the script (the script comes from cvs(1) background). Maybe i should change it to not use git porcelain but directly script the plumbing - :-) -, but i am *very* new to git(1) and in the meanwhile this simple patch pimps up my log output.
-- Ciao, Steffen sdaoden(*)(gmail.com) () ascii ribbon campaign - against html e-mail /\ www.asciiribbon.org - against proprietary attachments