Re: [PATCH v2] make pack-objects a bit more resilient to repo corruption

From: Nicolas Pitre <nico@fluxnic.net>
Date: Oct 22, 2010, 21:19 UTC
Message-ID: <alpine.LFD.2.00.1010221714450.2764@xanadu.home>
In-Reply-To: <AANLkTimy-ihrF1syWYe3T4W6-UHzCaj5Jud5rdFmv3D5@mail.gmail.com>

On Fri, 22 Oct 2010, Sverre Rabbelier wrote:

Show 10 quoted lines

> Heya,
> 
> On Fri, Oct 22, 2010 at 13:26, Nicolas Pitre <nico@fluxnic.net> wrote:
> > +                               static int warned = 0;
> > +                               if (!warned++)
> > +                                       warning("object %s cannot be read",
> > +                                               sha1_to_hex(src_entry->idx.sha1));
> 
> How does this handle multiple missing objects? Will it only warn for
> the first one?

Yes, only the first one, so you have a bone to chase if that ever happens to you. And that's good enough IMHO. Trying to warn for every missing object would require extra storage per object to remember if any particular object was warned for already, which is I think overkill for an extremely unlikely event. Comprehensive reporting is the job of fsck.

Nicolas