Re: [PATCH v2] make pack-objects a bit more resilient to repo corruption

From: Geert Bosch <bosch@adacore.com>
Date: Oct 24, 2010, 02:26 UTC
Message-ID: <30FC97D9-D9F2-4A08-8E69-4556DE204AA6@adacore.com>
In-Reply-To: <alpine.LFD.2.00.1010221714450.2764@xanadu.home>

On Oct 22, 2010, at 17:19, Nicolas Pitre wrote:

Show 15 quoted lines

>> On Fri, Oct 22, 2010 at 13:26, Nicolas Pitre <nico@fluxnic.net> wrote:
>>> +                               static int warned = 0;
>>> +                               if (!warned++)
>>> +                                       warning("object %s cannot be read",
>>> +                                               sha1_to_hex(src_entry->idx.sha1));
>> 
>> How does this handle multiple missing objects? Will it only warn for
>> the first one?
> 
> Yes, only the first one, so you have a bone to chase if that ever 
> happens to you.  And that's good enough IMHO.  Trying to warn for every 
> missing object would require extra storage per object to remember if any 
> particular object was warned for already, which is I think overkill for 
> an extremely unlikely event.  Comprehensive reporting is the job of 
> fsck.

Maybe add a ", run git fsck" to the message. Will still comfortably fit a line.

  -Geert