Re: [PATCH] Make xmalloc and xrealloc thread-safe
On Sat, 27 Mar 2010, Fredrik Kuivinen wrote:
Show 12 quoted lines
> On Wed, Mar 24, 2010 at 21:22, Nicolas Pitre <nico@fluxnic.net> wrote:
> > +static void try_to_free_from_threads(size_t size)
> > +{
> > + read_lock();
> > + release_pack_memory(size, -1);
> > + read_unlock();
> > +}
> > +
>
> Will this really work in all cases? In the find_deltas -> try_delta ->
> read_sha1_file -> ... -> xmalloc call path, the mutex is already
> locked when we get to xmalloc.You're right. Damn.
Nicolas
Nicolas Pitre <nico@fluxnic.net>