From: Nicolas Pitre <nico@fluxnic.net>
Date: Sat, 27 Mar 2010 18:59:41 GMT
Subject: Re: [PATCH] Make xmalloc and xrealloc thread-safe
Message-ID: <alpine.LFD.2.00.1003271035360.694@xanadu.home>
In-Reply-To: <4c8ef71003270626y45685e69j28ccb8a8738b9083@mail.gmail.com>

On Sat, 27 Mar 2010, Fredrik Kuivinen wrote:

> On Wed, Mar 24, 2010 at 21:22, Nicolas Pitre <nico@fluxnic.net> wrote:
> > +static void try_to_free_from_threads(size_t size)
> > +{
> > +       read_lock();
> > +       release_pack_memory(size, -1);
> > +       read_unlock();
> > +}
> > +
> 
> Will this really work in all cases? In the find_deltas -> try_delta ->
> read_sha1_file -> ... -> xmalloc call path, the mutex is already
> locked when we get to xmalloc.

You're right.  Damn.


Nicolas