Re: [PATCH] Make xmalloc and xrealloc thread-safe
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- Mar 24, 2010, 20:28 UTC
- Message-ID
- <20100324202814.GA24830@spearce.org>
- In-Reply-To
- <alpine.LFD.2.00.1003241613020.694@xanadu.home>
Nicolas Pitre <nico@fluxnic.net> wrote:
> Note: there was a dubious usage of fd when calling release_pack_memory() > in xmmap() which is now removed.
...
Show 6 quoted lines
> @@ -100,7 +112,7 @@ void *xmmap(void *start, size_t length,
> if (ret == MAP_FAILED) {
> if (!length)
> return NULL;
> - release_pack_memory(length, fd);
> + try_to_free_routine(length);This isn't dubious! The fd passed here is to prevent the pack release code from closing this fd right before we try to mmap it. Its an actual bug fix that I had to write years ago, check the history of that section of code... :-)
-- Shawn.