Re: how to suppress progress percentage in git-push

From: Nicolas Pitre <nico@fluxnic.net>
Date: Nov 23, 2009, 19:40 UTC
Message-ID: <alpine.LFD.2.00.0911231437460.2059@xanadu.home>
In-Reply-To: <20091123192518.GA1607@coredump.intra.peff.net>

On Mon, 23 Nov 2009, Jeff King wrote:

Show 16 quoted lines

> On Mon, Nov 23, 2009 at 11:56:43AM -0500, Nicolas Pitre wrote:
> 
> > > We need to do one of:
> > > 
> > >   1. make --all-progress imply "if we are using progress, then make it
> > >      more verbose. Otherwise, ignore."
> > > 
> > >   2. fix all callers to check isatty(2) before unconditionally passing
> > >      the option
> > 
> > None of the above would fix the issue as this only affects progress 
> > display for phase #3.  You'd still get progress display for the counting 
> > phase and the compressing phase.
> 
> I think it does fix the issue, as it is exactly the side effect that we
> are concerned about (and I tested my patch for 1, which squelched it).

Sorry, you were right.  I somehow understood something else initially.

> But your --all-progress-implied is a better fix, so I think we should go
> with that.

OK.

Nicolas