git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: how to suppress progress percentage in git-push

From
Jeff King <peff@peff.net>
Date
Nov 23, 2009, 19:28 UTC
Message-ID
<20091123192848.GB1607@coredump.intra.peff.net>
In-Reply-To
<20091123170547.GC26996@machine.or.cz>
On Mon, Nov 23, 2009 at 06:05:47PM +0100, Petr Baudis wrote:
Show 14 quoted lines
> > You wouldn't need to do anything that drastic. You would just need to
> > pass "--progress --all-progress" instead of only --all-progress. But you
> > have provided the data point that such a change would break at least one
> > user.
> > 
> > We could also leave --all-progress as-is and add new option to mean "if
> > you are already doing progress, do all progress".
> 
> Hmm, maybe I'm confused - I just call
> 
> 	git remote update
> 
> and don't pass any progress switches - would your change still affect
> me? Can I pass --progress to `git remote update`?

Oh, I misunderstood; I thought you were calling pack-objects directly. So you are actually relying on the "even though isatty(2) is not true, we always print progress messages" behavior? I think that behavior is buggy. It hurts everybody pushing via cron, and it violates the usual rule for when we show progress messages.

I don't think you can get a --progress pushed all the way down to the pack-objects in this case; we would need to add code to override the isatty check.

That being said, your example of "remote update" means you are dealing with fetch, and we are not touching the fetch code path at all.

-Peff
Previous: Petr BaudisNext: Nicolas Pitre
Message 6 of 16 in “how to suppress progress percentage in git-push”
  1. bill lamNov 22, 2009
  2. Jeff KingNov 23, 2009
  3. Petr BaudisNov 23, 2009
  4. Jeff KingNov 23, 2009
  5. Petr BaudisNov 23, 2009
  6. Jeff KingNov 23, 2009
  7. pack-objects: split implications of --all-progress from progress activationNicolas Pitre, Nov 23, 2009
  8. Petr BaudisNov 23, 2009
  9. Nicolas PitreNov 23, 2009
  10. Petr BaudisNov 23, 2009
  11. Jeff KingNov 23, 2009
  12. Nicolas PitreNov 23, 2009
  13. Jeff KingNov 23, 2009
  14. Nicolas PitreNov 23, 2009
  15. bill lamNov 24, 2009
  16. Jeff KingNov 24, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.