Re: [PATCH] pack-objects: split implications of --all-progress from progress activation

From: Nicolas Pitre <nico@fluxnic.net>
Date: Nov 23, 2009, 18:27 UTC
Message-ID: <alpine.LFD.2.00.0911231323010.2059@xanadu.home>
In-Reply-To: <20091123181206.GD26996@machine.or.cz>

On Mon, 23 Nov 2009, Petr Baudis wrote:

Show 17 quoted lines

> On Mon, Nov 23, 2009 at 12:43:50PM -0500, Nicolas Pitre wrote:
> > Currently the --all-progress flag is used to use force progress display 
> > during the writing object phase even if output goes to stdout which is 
> > primarily the case during a push operation.  This has the unfortunate 
> > side effect of forcing progress display even if stderr is not a 
> > terminal.
> > 
> > Let's introduce the --all-progress-implied argument which has the same 
> > intent except for actually forcing the activation of any progress 
> > display.  With this, progress display will be automatically inhibited 
> > whenever stderr is not a terminal, or full progress display will be 
> > included otherwise.  This should let people use 'git push' within a cron 
> > job without filling their logs with useless percentage displays.
> > 
> > Signed-off-by: Nicolas Pitre <nico@fluxnic.net>
> 
> Ok, but what is currently the way to force the old behaviour?

If any existing out-of-tree users of pack-objects were using --all-progress then nothing has changed for them.

Show 6 quoted lines

> I believe that should be also part of the commit message.
> 
> Naive deduction fails:
> 
> 	$ git remote update --progress
> 	error: unknown option `progress'

Usage of 'git remote" is about fetching and not pushing, right? My patch only affects pushes. So I don't know what old behavior you're after.

Nicolas