git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] pack-objects: report actual number of threads to be used

From
Nicolas Pitre <nico@cam.org>
Date
Apr 6, 2009, 03:14 UTC
Message-ID
<alpine.LFD.2.00.0904052311020.6741@xanadu.home>
In-Reply-To
<449c10960904051934l54d2d504w1af867dc53ef7dd7@mail.gmail.com>
On Sun, 5 Apr 2009, Dan McGee wrote:
Show 33 quoted lines
> On Sun, Apr 5, 2009 at 9:31 PM, Nicolas Pitre <nico@cam.org> wrote:
> > The number currently displayed has real meaning: this is the number of
> > threads git is allowed to use.  The number of threads it will actually
> > use is variable and it changes with time.
> 
> Would something like this be more ideal then? I wouldn't be so
> persistent here if the current text wasn't misleading in a case like
> the following:
> 
> dmcgee@galway ~/projects/devtools (master)
> $ git push origin
> Counting objects: 13, done.
> Delta compression using 4 threads.
> Compressing objects: 100% (8/8), done.
> Writing objects: 100% (8/8), 1.28 KiB, done.
> Total 8 (delta 6), reused 0 (delta 0)
> To archlinux.org:/srv/projects/git/devtools.git
>    bcb0e39..ea73c2b  master -> master
> 
> diff --git a/builtin-pack-objects.c b/builtin-pack-objects.c
> index 9fc3b35..99181fd 100644
> --- a/builtin-pack-objects.c
> +++ b/builtin-pack-objects.c
> @@ -1612,7 +1612,7 @@ static void ll_find_deltas(struct object_entry
> **list, unsigned list_size,
>                 return;
>         }
>         if (progress > pack_to_stdout)
> -               fprintf(stderr, "Delta compression using %d threads.\n",
> +               fprintf(stderr, "Delta compression using up to %d threads.\n",
>                                 delta_search_threads);
> 
>         /* Partition the work amongst work threads. */
This I have absolutely no issue with.
Acked-by: Nicolas Pitre <nico@cam.org>
Nicolas
Previous: Dan McGeeNext: Junio C Hamano
Message 10 of 14 in “git-repack: use non-dashed update-server-info”
  1. 1/2 git-repack: use non-dashed update-server-infoDan McGee, Apr 4, 2009
  2. 2/2 pack-objects: report actual number of threads to be usedDan McGee, Apr 4, 2009
  3. Jeff KingApr 4, 2009
  4. Dan McGeeApr 4, 2009
  5. Jeff KingApr 4, 2009
  6. Nicolas PitreApr 5, 2009
  7. Dan McGeeApr 6, 2009
  8. Nicolas PitreApr 6, 2009
  9. Dan McGeeApr 6, 2009
  10. Nicolas PitreApr 6, 2009
  11. Junio C HamanoApr 8, 2009
  12. Update delta compression message to be less misleadingDan McGee, Apr 9, 2009
  13. Junio C HamanoApr 11, 2009
  14. Dan McGeeApr 11, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.