git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] pack-objects: report actual number of threads to be used

From
Jeff King <peff@peff.net>
Date
Apr 4, 2009, 18:06 UTC
Message-ID
<20090404180601.GA14888@coredump.intra.peff.net>
In-Reply-To
<1238864396-8964-2-git-send-email-dpmcgee@gmail.com>
On Sat, Apr 04, 2009 at 11:59:56AM -0500, Dan McGee wrote:
Show 13 quoted lines
> In the case of a small repository, pack-objects is smart enough to not start
> more threads than necessary. However, the output to the user always reports
> the value of the pack.threads configuration and not the real number of
> threads to be used. This is easily fixed by moving the printing of the
> message after we have partitioned our work.
> 
> (pack.threads is on autodetect and would be set to 4)
> $ git-repack -a -d -f
> Counting objects: 55, done.
> Delta compression using 2 threads.
> Compressing objects: 100% (48/48), done.
> Writing objects: 100% (55/55), done.
> Total 55 (delta 10), reused 0 (delta 0)

That makes sense to me, though I wonder if it may confuse and frustrate users who are expecting their awesome quad-core machine to be using 4 threads when it only uses 2. Is it worth printing both values, or some indicator that we could have been using more?

-Peff
Previous: Dan McGeeNext: Dan McGee
Message 3 of 14 in “git-repack: use non-dashed update-server-info”
  1. 1/2 git-repack: use non-dashed update-server-infoDan McGee, Apr 4, 2009
  2. 2/2 pack-objects: report actual number of threads to be usedDan McGee, Apr 4, 2009
  3. Jeff KingApr 4, 2009
  4. Dan McGeeApr 4, 2009
  5. Jeff KingApr 4, 2009
  6. Nicolas PitreApr 5, 2009
  7. Dan McGeeApr 6, 2009
  8. Nicolas PitreApr 6, 2009
  9. Dan McGeeApr 6, 2009
  10. Nicolas PitreApr 6, 2009
  11. Junio C HamanoApr 8, 2009
  12. Update delta compression message to be less misleadingDan McGee, Apr 9, 2009
  13. Junio C HamanoApr 11, 2009
  14. Dan McGeeApr 11, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.