Re: [PATCH] Wrap inflateInit to retry allocation after releasing pack memory

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Jan 8, 2009, 20:22 UTC
Message-ID: <alpine.LFD.2.00.0901081216060.3283@localhost.localdomain>
In-Reply-To: <1231438552.8870.645.camel@starfruit>

On Thu, 8 Jan 2009, R. Tyler Ballance wrote:

Show 5 quoted lines

> > 
> > Tyler - does this make the corruption errors go away, and be replaced by 
> > hard failures with "out of memory" reporting?
> 
> Yeah, looks like it:

Well, I was hoping that you'd have a confirmation from your own huge repo, but I do suspect it's all the same thing, so I guess this counts as confirmation too.

Show 6 quoted lines

> > This patch is potentially pretty noisy, on purpose. I didn't remove the 
> > reporting from places that already do so - some of them have stricter 
> > errors than this.
> 
> I'm assuming this patch is going to be reworked, if so, I'll back it out
> of our internal 1.6.1 build and anxiously await The Real Deal(tm)

Oh, it shouldn't be any noisier under _normal_ load - it's more that certain real corruption cases will now report the error twice. That said, the new errors should actually be more informative than the old ones, so even that isn't necessarily all bad.

Junio - I think we should apply this, and likely to the stable branch too. Add the re-trying the inflateInit() after shrinking pack windows on top of it.

			Linus