Re: Public repro case! Re: [PATCH/RFC] Allow writing loose objects that are corrupted in a pack file

From: Shawn O. Pearce <spearce@spearce.org>
Date: Jan 8, 2009, 02:43 UTC
Message-ID: <20090108024325.GE10790@spearce.org>
In-Reply-To: <885649360901071821t2ea481b5k83ab800f6aeb897@mail.gmail.com>

James Pickens <jepicken@gmail.com> wrote:

Show 8 quoted lines

> On Wed, Jan 7, 2009, Linus Torvalds <torvalds@linux-foundation.org> wrote:
> > Can you cnfirm that your "reproducible" case starts working with that
> > addition to your ~/.gitconfig? If so, the solution is pretty simple: we
> > should just lower the default pack windowsize.
> 
> Umm... isn't that more of a workaround than a solution?  I.e., if you lower
> the default pack windowsize, couldn't the corruption still happen under the
> right conditions?

Uhm, yea. So I managed to reproduce it on a Linux system here. Different object ids than R. Tyler's case, but I'm going to try to debug it and see why we are getting these.

For those following along at home, Linus' 2.6 tree:

$ ulimit -v `echo '150 * 1024'|bc -l` $ git co 56d18e9932ebf4e8eca42d2ce509450e6c9c1666 HEAD is now at 56d18e9... Merge branch 'upstream' of git://ftp.linux-mips.org/pub/scm/upstream-linus $ git merge 9e42d0cf5020aaf217433cad1a224745241d212a Updating 56d18e9..9e42d0c error: failed to read delta base object ef135b90084f3c54fccea4e273aeff029db2d873 at offset 48342508 from .git/objects/pack/pack-edb47354be787909e05c15bd1d9eb8b4684d2e4d.pack error: failed to read delta base object c4e828b71d96622bb258938d69aab9cec53d5cae at offset 128427683 from .git/objects/pack/pack-edb47354be787909e05c15bd1d9eb8b4684d2e4d.pack error: failed to read object 3cd5a6463cfd9306095bf6312a9b7ab09d4f2f5d at offset 128427777 from .git/objects/pack/pack-edb47354be787909e05c15bd1d9eb8b4684d2e4d.pack fatal: object 3cd5a6463cfd9306095bf6312a9b7ab09d4f2f5d is corrupted

No, the repository is not corrupt. We f'd up our memory management somewhere.

-- 
Shawn.