git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] sideband.c: Use xmalloc() instead of variable-sized arrays.

From
Nicolas Pitre <nico@cam.org>
Date
Jan 8, 2008, 17:01 UTC
Message-ID
<alpine.LFD.1.00.0801081154460.3054@xanadu.home>
In-Reply-To
<4783A3B2.3060801@viscovery.net>
On Tue, 8 Jan 2008, Johannes Sixt wrote:
Show 5 quoted lines
> From: Johannes Sixt <johannes.sixt@telecom.at>
> 
> How come we got along with this not very portable construct for so long?
> Probably because the array sizes were computed from the results of
> strlen() of string constants.

Maybe because it isn't not so unportable anymore? I doubt that compilers that don't know about automatic arrays would be smart enough to notice the variable was actually a constant due to the strlen() of a constant string and just do like if there wasn't any variable for the array size.

> Anyway, a follow-up patch will make the
> lengths really non-constant.
Fair enough.
Nicolas
Previous: Johannes SixtNext: Johannes Sixt
Message 2 of 11 in “sideband.c: Use xmalloc() instead of variable-sized arrays.”
  1. 1/2 sideband.c: Use xmalloc() instead of variable-sized arrays.Johannes Sixt, Jan 8, 2008
  2. Nicolas PitreJan 8, 2008
  3. Johannes SixtJan 9, 2008
  4. Junio C HamanoJan 9, 2008
  5. Johannes SixtJan 9, 2008
  6. Nicolas PitreJan 9, 2008
  7. Junio C HamanoJan 8, 2008
  8. Nicolas PitreJan 8, 2008
  9. Junio C HamanoJan 8, 2008
  10. Nicolas PitreJan 8, 2008
  11. Johannes SixtJan 9, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.