Re: [PATCH 1/2] sideband.c: Use xmalloc() instead of variable-sized arrays.
- From
Johannes Sixt <j.sixt@viscovery.net>
- Date
- Jan 9, 2008, 07:26 UTC
- Message-ID
- <4784772A.1060704@viscovery.net>
- In-Reply-To
- <7v4pdotdtl.fsf@gitster.siamese.dyndns.org>
Junio C Hamano schrieb:
Show 14 quoted lines
> Johannes Sixt <j.sixt@viscovery.net> writes:
>> @@ -19,7 +19,10 @@ int recv_sideband(const char *me, int in_stream, int out, int err)
>> {
>> unsigned pf = strlen(PREFIX);
>> unsigned sf = strlen(SUFFIX);
>> - char buf[pf + LARGE_PACKET_MAX + sf + 1];
>> + char *buf, *save;
>> +
>> + save = xmalloc(sf);
>> + buf = xmalloc(pf + LARGE_PACKET_MAX + sf + 1);
>
> I have to wonder if the malloc() overhead is small enough
> compared to the network bandwidth to make a two malloc-free
> pairs per packet a non-issue...recv_sideband() is called _once_per_connection_ and not for each packet. Hence, these two mallocs should not concern us.
-- Hannes