From: Nicolas Pitre <nico@cam.org>
Date: Tue, 08 Jan 2008 17:01:07 GMT
Subject: Re: [PATCH 1/2] sideband.c: Use xmalloc() instead of variable-sized arrays.
Message-ID: <alpine.LFD.1.00.0801081154460.3054@xanadu.home>
In-Reply-To: <4783A3B2.3060801@viscovery.net>

On Tue, 8 Jan 2008, Johannes Sixt wrote:

> From: Johannes Sixt <johannes.sixt@telecom.at>
> 
> How come we got along with this not very portable construct for so long?
> Probably because the array sizes were computed from the results of
> strlen() of string constants.

Maybe because it isn't not so unportable anymore?  I doubt that 
compilers that don't know about automatic arrays would be smart enough 
to notice the variable was actually a constant due to the strlen() of a 
constant string and just do like if there wasn't any variable for the 
array size.

> Anyway, a follow-up patch will make the
> lengths really non-constant.

Fair enough.


Nicolas