Re: [PATCH] Add a message explaining that automatic GC is about to start
- From
Nicolas Pitre <nico@cam.org>
- Date
- Oct 18, 2007, 14:21 UTC
- Message-ID
- <alpine.LFD.0.9999.0710181019080.19446@xanadu.home>
- In-Reply-To
- <3391BADA-B5B4-4A8E-A6C0-42169AFC0331@silverinsanity.com>
On Thu, 18 Oct 2007, Brian Gernhardt wrote:
Show 18 quoted lines
> > On Oct 18, 2007, at 12:41 AM, koreth@midwinter.com wrote: > > > And as an added bonus, we can tell people how to turn off automatic GC > > and how to invoke it by hand. > > > + fprintf(stderr, "Packing your repository for optimum " > > + "performance. If you would rather run\n" > > + "\"git gc\" by hand, run \"git config gc.auto 0\" " > > + "to disable automatic cleanup.\n"); > > I'm not sure telling the users how to disable it every time it shows up is a > good idea. gc --auto exists for the naive user, and suggesting they turn it > off each time it happens will just result in... people turning it off, > leading back to the performance issues that caused the feature to be installed > in the first place. Perhaps a message more along the lines of "To avoid this, > run "git gc" manually on a regular basis. See 'git help gc' for more > information."
This is indeed a good point.
And for those who start repacking manually then the automatic repacking will very rarely trigger, reducing the need for turning automatic repacking off anyway.
Nicolas