Re: [PATCH 07/25] parse-options: make some arguments optional, add callbacks.

From: Nicolas Pitre <nico@cam.org>
Date: Oct 16, 2007, 16:44 UTC
Message-ID: <alpine.LFD.0.9999.0710161244190.19446@xanadu.home>
In-Reply-To: <4714E90C.80305@lsrfire.ath.cx>

On Tue, 16 Oct 2007, René Scharfe wrote:

Show 14 quoted lines

> Pierre Habouzit schrieb:
> > This bit is to allow to aggregate options with arguments together when
> > the argument is numeric.
> > 
> >     +#if 0
> >     +		/* can be used to understand -A1B1 like -A1 -B1 */
> >     +		if (flag & OPT_SHORT && opt->opt && isdigit(*opt->opt)) {
> >     +			*(int *)opt->value = strtol(opt->opt, (char **)&opt->opt, 10);
> >     +			return 0;
> >     +		}
> >     +#endif
> 
> I don't like it, it complicates number options with unit suffixes (e.g.
> --windows-memory of git-pack-objects).

This is my opinion too.

Nicolas