Re: [PATCH 07/25] parse-options: make some arguments optional, add callbacks.

From: Shawn O. Pearce <spearce@spearce.org>
Date: Oct 17, 2007, 04:44 UTC
Message-ID: <20071017044405.GV13801@spearce.org>
In-Reply-To: <20071016165045.GB13946@artemis.corp>

Pierre Habouzit <madcoder@debian.org> wrote:

Show 15 quoted lines

> On Tue, Oct 16, 2007 at 04:38:36PM +0000, René Scharfe wrote:
> > Pierre Habouzit schrieb:
> > > This bit is to allow to aggregate options with arguments together when
> > > the argument is numeric.
> > > 
> > >     +#if 0
> > >     +		/* can be used to understand -A1B1 like -A1 -B1 */
> > >     +		if (flag & OPT_SHORT && opt->opt && isdigit(*opt->opt)) {
> > >     +			*(int *)opt->value = strtol(opt->opt, (char **)&opt->opt, 10);
> > >     +			return 0;
> > >     +		}
> > >     +#endif
> > 
> > I don't like it, it complicates number options with unit suffixes (e.g.
> > --windows-memory of git-pack-objects).

...

>   This is a very strong argument _against_ this chunk IMO.

Since everyone (including myself) is apparently strongly against this hunk I removed it when I cherry-picked this series from Pierre into my tree. The series will be in my pu tonight, but minus this hunk.

-- 
Shawn.