Re: [PATCH 07/25] parse-options: make some arguments optional, add callbacks.
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Oct 16, 2007, 16:44 UTC
- Message-ID
- <Pine.LNX.4.64.0710161742040.25221@racer.site>
- In-Reply-To
- <4714E90C.80305@lsrfire.ath.cx>
Hi,
On Tue, 16 Oct 2007, Ren? Scharfe wrote:
Show 14 quoted lines
> Pierre Habouzit schrieb:
> > This bit is to allow to aggregate options with arguments together when
> > the argument is numeric.
> >
> > +#if 0
> > + /* can be used to understand -A1B1 like -A1 -B1 */
> > + if (flag & OPT_SHORT && opt->opt && isdigit(*opt->opt)) {
> > + *(int *)opt->value = strtol(opt->opt, (char **)&opt->opt, 10);
> > + return 0;
> > + }
> > +#endif
>
> I don't like it, it complicates number options with unit suffixes (e.g.
> --windows-memory of git-pack-objects).Why? It only means that you cannot say -W10mxabc instead of -W10m xabc.
Remember: this is a special case for OPT_INTEGER. Nothing to do with OPT_SIZE, which you'd probably implement as a callback.
Ciao, Dscho