Re: [RFD/PATCH] Implement pack.compression and pack-objects --compression=N

From: Nicolas Pitre <nico@cam.org>
Date: May 4, 2007, 20:17 UTC
Message-ID: <alpine.LFD.0.99.0705041609260.24220@xanadu.home>
In-Reply-To: <56b7f5510705041251v1a09103eif677c02efc53059e@mail.gmail.com>

On Fri, 4 May 2007, Dana How wrote:

Show 13 quoted lines

> Now that I'm awake your original quote at the top suggests:
> (a) zlib_compression_level =
>     isset(core.loosecompression) ? core.loosecompression :
>     isset(core.compression) ? core.compression : Z_BEST_SPEED;
> (b) pack_compression_level =
>     isset(pack.compression) ? pack.compression :
>     isset(core.compression) ? core.compression : Z_DEFAULT_COMPRESSION;
> 
> Your later reaction to my quoted (a)/(b) table suggests:
> (a) zlib_compression_level =
>     isset(core.compression) ? core.compression : Z_BEST_SPEED;
> (b) pack_compresion_level =
>     isset(pack.compression) ? pack.compression : Z_DEFAULT_COMPRESSION;

My final comment is that I think the former looks more coherent, while the later is simpler to implement.

Nicolas