Re: [RFD/PATCH] Implement pack.compression and pack-objects --compression=N

From: Junio C Hamano <junkio@cox.net>
Date: May 4, 2007, 05:49 UTC
Message-ID: <7vejlxxho1.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <56b7f5510705021551q2d48f1e5i3f4a5c2f9891368a@mail.gmail.com>

"Dana How" <danahow@gmail.com> writes:

Show 5 quoted lines

> So for a 25% increase in blob size I get 33% less elapsed time
> in git-add, all by changing core.compression from -1 to 1.
> I'll definitely take that improvement.  [For the compressible files
> we typically have, using 0 is a bad idea:  the CPU "advantage"
> is swamped out by the time to write a much larger file.]

The above number is about loose objects, right?

> Since I don't care [to the same degree] about the responsiveness of
> packing,  I'd rather pack with -1 or better to keep packs small.

I see. You are saying that the fact that core.compression is used also for packing makes the variable less useful.

I agree that it would make sense to have at least the pack and core compression independent. I am not sure if we would also want to make the pack compression tweakable depending on the purpose of the packing (network transfer vs .git/objects/pack/).

> (And inflation time seems independent of compression setting.)

True.