Re: [PATCH] Create pack-write.c for common pack writing code

From: Nicolas Pitre <nico@cam.org>
Date: May 2, 2007, 16:29 UTC
Message-ID: <alpine.LFD.0.98.0705021226010.6574@xanadu.home>
In-Reply-To: <20070502161648.GK5942@spearce.org>

On Wed, 2 May 2007, Shawn O. Pearce wrote:

Show 11 quoted lines

> Dana How <danahow@gmail.com> wrote:
> > 
> > Include a generalized fixup_header_footer() in this new file.
> > Needed by git-repack --max-pack-size feature in a later patchset.
> 
> Thanks.  I'm applying this to my fastimport.git tree, but I changed
> the name to fixup_pack_header_footer().  I'm also refactoring the
> same code out of index-pack, to call your version.
> 
> I'll ask Junio to pull your patch, and my index-pack cleanup soon.
> As soon as I'm sure everything still passes the tests.  ;-)

BTW I think the common function should _not_ close the file descriptor it is being handed. It is more flexible to let the caller close the file, or possibly do whatever other operations like fchmod().

Nicolas