Re: [PATCH] Create pack-write.c for common pack writing code

From: Dana How <danahow@gmail.com>
Date: May 2, 2007, 17:25 UTC
Message-ID: <56b7f5510705021025j23e2ca3al7a72aeee33ff86aa@mail.gmail.com>
In-Reply-To: <20070502161648.GK5942@spearce.org>

On 5/2/07, Shawn O. Pearce <spearce@spearce.org> wrote:

Show 9 quoted lines

> Dana How <danahow@gmail.com> wrote:
> > Include a generalized fixup_header_footer() in this new file.
> > Needed by git-repack --max-pack-size feature in a later patchset.
> Thanks.  I'm applying this to my fastimport.git tree, but I changed
> the name to fixup_pack_header_footer().  I'm also refactoring the
> same code out of index-pack, to call your version.
>
> I'll ask Junio to pull your patch, and my index-pack cleanup soon.
> As soon as I'm sure everything still passes the tests.  ;-)

Sounds good. I didn't refactor index-pack.c since that wasn't what we discussed; pulling out the close() as you or Nicolas later write is the only thing needed to include it too.

At this point, I guess there's not much left to comment on in the --max-pack-size=N patchset? Should I update it for your _pack name change/moving out the close()? I' feel like I've really spammed the list with the versions of this patchset (5 so far).

Also, any reaction to the pack.compression/--compression=N patch? It was the smallest code delta/most significant low-hanging fruit I could identify for my day-job workflow's performance.

Thanks,

-- 
Dana L. How  danahow@gmail.com  +1 650 804 5991 cell