Re: [PATCH] Create pack-write.c for common pack writing code
- From
Shawn O. Pearce <spearce@spearce.org>
- Date
- May 2, 2007, 16:31 UTC
- Message-ID
- <20070502163122.GL5942@spearce.org>
- In-Reply-To
- <alpine.LFD.0.98.0705021226010.6574@xanadu.home>
Nicolas Pitre <nico@cam.org> wrote:
> BTW I think the common function should _not_ close the file descriptor > it is being handed. It is more flexible to let the caller close the > file, or possibly do whatever other operations like fchmod().
I didn't mention it, but I agree, and fixed it in Dana's patch.
-- Shawn.