Re: [PATCH] t5300-pack-object.sh: portability issue using /usr/bin/stat

From: Nicolas Pitre <nico@cam.org>
Date: Apr 7, 2007, 12:39 UTC
Message-ID: <alpine.LFD.0.98.0704070831140.28181@xanadu.home>
In-Reply-To: <7vabxkhleh.fsf@assigned-by-dhcp.cox.net>

On Fri, 6 Apr 2007, Junio C Hamano wrote:

Show 9 quoted lines

> Nicolas Pitre <nico@cam.org> writes:
> 
> > On Fri, 6 Apr 2007, Junio C Hamano wrote:
> >
> > Well... since this test already depends on wc then why not just use that 
> > instead of adding a perl dependency?
> 
> Because (1) other tests already use Perl; (2) wc -c reads pack
> to find out the size, "-s $file" doesn't AFAIK.

Maybe. But my point is that wc is already used to find file size in other part of the test. So it should at least be consistent. And my patch has the advantage of looking much simpler.

Nicolas